Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "fill-antialias" property #4093

Open
lucaswoj opened this issue Feb 1, 2017 · 7 comments
Open

Remove "fill-antialias" property #4093

lucaswoj opened this issue Feb 1, 2017 · 7 comments
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Feb 1, 2017

From @ansis on June 11, 2015 19:39

fill-antialias is useless. Theoretically you could disable antialiasing to get a tiny performance improvement if the fill edges are covered by something else (a thick line outline). In practice the performance improvement is insignificant.

Copied from original issue: mapbox/mapbox-gl-style-spec#289

@lucaswoj lucaswoj added the breaking change ⚠️ Requires a backwards-incompatible change to the API label Feb 1, 2017
@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @nickidlugash on June 15, 2015 15:59

@ansis Want to add to v8?

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @ansis on June 15, 2015 18:25

added

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @kkaefer on June 16, 2015 11:24

In practice the performance improvement is insignificant.

Not sure about this. Do you have any numbers? I've seen performance boosts for detailed polygons, like forest areas.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @ansis on June 16, 2015 15:37

nope, I don't have any numbers. I was guessing that since the property could be used without visual defects in only a very small number of cases it wouldn't have any big impact on total performance.

I have a hard time imagining anyone actually using this property in a style, so I don't think we should have it in the editor or spec.

I'm fine with keeping it if you think people will actually use it.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @jfirebaugh on August 6, 2015 18:47

This doesn't block app, right? If so let's not change it in v8.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @ajashton on January 25, 2017 2:4

When dealing with transparent overlapping shapes and subtle color shifts the aliased polygons tend to actually look better (especially on hidpi). We have fill-antialias disabled in hillshading layers for several styles to avoid problems with overlapping transparency (note both the seams due to lack of buffers and the darker outline around the full outline of each hillshade polygon):

screenshot from 2017-01-24 20 57 11

I would also like to see some numbers re: performance on some dense layers such as hillshading and landuse.

@1ec5 1ec5 added the cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) label Feb 3, 2017
@xabbu42
Copy link

xabbu42 commented Apr 9, 2020

We also disable antialiasing on zoomed out tiles for our forest polygons as with antialiasing they tend to all blend together to one big area (compare the lower left corner of the following tiles):

antialias

noantialias

By the way is this stark visual difference from antialiasing expected or should I open a new issue about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
Projects
None yet
Development

No branches or pull requests

3 participants