Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage developers from adding canvas sources to style JSON #5545

Closed
1ec5 opened this issue Oct 27, 2017 · 1 comment
Closed

Discourage developers from adding canvas sources to style JSON #5545

1ec5 opened this issue Oct 27, 2017 · 1 comment

Comments

@1ec5
Copy link
Contributor

1ec5 commented Oct 27, 2017

The canvas source type documentation should state that canvas sources are only to be used at runtime in JavaScript code, never in style JSON. This source type is inherently platform-specific: some platforms like iOS have no concept of a rendering surface associated with a unique identifier. A platform-specific source type has no place in a file format that’s intended to be portable across platforms.

Ideally, canvas would be omitted entirely from the style specification. However, GL JS uses the style specification to document its runtime styling API, so that isn’t an option right now.

/cc @anandthakker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants