-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small-radius heatmap flickers when moving the map #5563
Comments
Wow, not sure what's going on there.... |
@mourner the effect sort of reminds me of something I ran into in fill-extrusion layers in gl-native, where sometimes the depth buffer resolution was too low (mapbox/mapbox-gl-native#8431 (comment)), causing jagged edges on the sides of extrusions; we fixed this by setting the near clip plan in the fill-extrusion layer projection matrix to 100 so as not to waste a lot of precision on shapes extremely close to the camera (mapbox/mapbox-gl-native@72278bf). Not sure if this is relevant to what's going on here, but 🤷♀️ |
I don't think this is as much a "further distances" problem as much as a "small radius" problem. Radii above 5 seems to behave well. Radii 3 and under seem to flicker. |
Agree with @wysisoft, there is no need to pitch a heatmap to trigger the bug. This GIF is just the official example zoomed out so that |
Thanks for pointing out what's going on here @pathmapper and @wysisoft I can confirm that this is reproducible in our debug heatmap page as well, if you lower the |
This is an aliasing issue caused by too low texture resolution in heatmap rendering. Information is lost when the heatmap is rendered to an offscreen texture that has 1/16 size of the viewport. Here's an another example of the bug: |
Pitching maps with heatmap layers cause "far" kernels to change on every frame (kind of flicker, in a blurry heatmap sort of way).
Reproducible on any heatmap, including the examples page.
cc @mourner
The text was updated successfully, but these errors were encountered: