Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors interpolated with 'hcl' colorSpace disappear. #5808

Closed
stevage opened this issue Dec 5, 2017 · 1 comment · Fixed by #5843
Closed

Colors interpolated with 'hcl' colorSpace disappear. #5808

stevage opened this issue Dec 5, 2017 · 1 comment · Fixed by #5843
Assignees

Comments

@stevage
Copy link
Contributor

stevage commented Dec 5, 2017

mapbox-gl-js version: 0.42.2

Steps to Trigger Behavior

  1. Set up a layer of points that interpolates in the 'hcl' colorspace from 'red' to 'blue

Expected Behavior

Every point renders some color, probably shades of purple, similar to with 'rgb' colorSpace:

https://codepen.io/stevebennett/pen/pdYmwq

Actual Behavior

Some points don't render at all.

https://codepen.io/stevebennett/pen/OOqYpz

I imagine that what's happening is the interpolation is pushing the colors outside the colorspace, maybe generating non-sensible colors. But I don't think the user ever wants invisible colors.

Side note: it's slightly frustrating that colors are specified as HSL, but can't be interpolated in HSL. The interpolation from hsl(0, 100%, 50%) to hsl(240, 100%, 50%) should be really clear, but presumably in HCL colorspace it is, um, 'clear' in a different sense.

@jfirebaugh jfirebaugh self-assigned this Dec 5, 2017
@jfirebaugh
Copy link
Contributor

This regressed in 670108d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants