-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider "className" option to Popup #6299
Comments
In the past we've suggested applying classes to your user content and styling based on that. Is there a case where that doesn't suffice? |
Yes, as described above:
To spell it out more: currently you can only style the content of the popup individually. Which means every popup will share the same (by default, white, padded, dark outlined) frame. If you want to have hover-over popups without the padding and frame (which I do), but also have click popups with the padding and frame, you can't do that just by changing the styling of |
I add this option in PR #6502 |
Currently all popups created using Popup are created with this structure:
Which is fine for styling if you only have one "type" of popup. But sometimes you have hover-over popups, and click popups, which you want to style differently: less padding in the former case.
It's currently very difficult to achieve this, because the outer two layers of
<div>
are identical in both cases.Suggestion:
which would lead to:
The text was updated successfully, but these errors were encountered: