Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "popup.open" event #6302

Closed
jmeyers91 opened this issue Mar 8, 2018 · 3 comments
Closed

Add a "popup.open" event #6302

jmeyers91 opened this issue Mar 8, 2018 · 3 comments

Comments

@jmeyers91
Copy link
Contributor

jmeyers91 commented Mar 8, 2018

Basically the same as Add a "popup.close" event except an open event should also trigger when the popup opens.

Expected Behavior

This should log 'open' to the console when the popup opens:

let popup = new mapboxgl.Popup()
popup.on('open', function(e) {
    console.log('open');
})

Actual Behavior

The open event is never fired.

@jfirebaugh
Copy link
Contributor

Hey @jmeyers91! This would make a good first contribution. Would you like to take a stab at a PR?

@jmeyers91
Copy link
Contributor Author

Sure

@jfirebaugh
Copy link
Contributor

Done in #6311. Thanks @jmeyers91!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants