Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorporate a css build system #6493

Closed
andrewharvey opened this issue Apr 10, 2018 · 1 comment · Fixed by #6513
Closed

incorporate a css build system #6493

andrewharvey opened this issue Apr 10, 2018 · 1 comment · Fixed by #6513
Assignees
@andrewharvey
Labels
workflow 💅

Comments

@andrewharvey
Copy link
Collaborator

It can be painstaking to edit the inline svg assets in mapbox-gl.css by hand.

There is also inconstancy, some are base64 encoded others url encoded.

Should we convert the mapbox-gl.css into SASS and use https://www.npmjs.com/package/sass-inline-svg to automatically base64 and inline SVG assets.
@andrewharvey andrewharvey mentioned this issue Apr 10, 2018
Merged
5 tasks
@anandthakker
Copy link
Contributor

Good idea, though I'd be more inclined towards PostCSS over SASS.

@andrewharvey andrewharvey mentioned this issue Apr 14, 2018
Merged
3 tasks
@andrewharvey andrewharvey self-assigned this Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewharvey andrewharvey

Labels
workflow 💅
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use postcss to inline svg files into css mapbox/mapbox-gl-js
2 participants
@andrewharvey @anandthakker