Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install breaks tests #6774

Open
ryanhamley opened this issue Jun 1, 2018 · 3 comments · May be fixed by #10948
Open

npm install breaks tests #6774

ryanhamley opened this issue Jun 1, 2018 · 3 comments · May be fixed by #10948

Comments

@ryanhamley
Copy link
Contributor

mapbox-gl-js version: 0.45.0

Steps to Trigger Behavior

  1. npm install
  2. yarn test

Expected Behavior

npm install and yarn install will produce the same output so that all tests will pass correctly

Actual Behavior

npm install bypasses the yarn.lock file and installs a newer version of @mapbox/batfish that breaks some tests.

Possible solution

set up npm install to fallback to yarn with the use-yarn node module

@andrewharvey
Copy link
Collaborator

With the latest master and batfish version, the tests pass even when using npm install. That said, I think use-yarn is a good idea to prevent this issue popping up in the future.

@asheemmamoowala
Copy link
Contributor

@ryanhamley The contributing docs only every mention using yarn with this project. Is there a use-case or reason fro needing to support npm?

@ryanhamley
Copy link
Contributor Author

Just that it's very common for people to use npm install then wonder why things aren't working

@asheemmamoowala asheemmamoowala linked a pull request Oct 27, 2021 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants