Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce line buffers back from 12 to 8 bytes per vertex #8304

Closed
mourner opened this issue May 30, 2019 · 1 comment
Closed

Reduce line buffers back from 12 to 8 bytes per vertex #8304

mourner opened this issue May 30, 2019 · 1 comment
Assignees
@mourner
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage

Comments

@mourner
Copy link
Member

mourner commented May 30, 2019

A part of #8243. PRs #5073 followed by #5258, aiming to fix an obscure Broadcom GPU bug, also increased the amount of data we upload to the GPU for line layers by 50% — from 8 to 12 bytes. This directly affects rendering performance.

We should explore alternative packing approaches to get this back to 8 bytes while avoiding the GPU bug trigger. One thing to try would be to try packing the round/up attributes into most significant bit rather than least significant. cc @ansis
@mourner mourner added the performance ⚡ Speed, stability, CPU usage, memory usage, or power usage label May 30, 2019
@mourner mourner self-assigned this May 30, 2019
@mourner mourner mentioned this issue May 30, 2019
Merged
8 tasks
@ahk ahk mentioned this issue Jun 4, 2019
Closed
@mourner
Copy link
Member Author

mourner commented Jun 11, 2019

Fixed in #8306

@mourner mourner closed this as completed Jun 11, 2019
@ansis ansis mentioned this issue Nov 14, 2019
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mourner mourner

Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mourner