Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate array enums for symbol layer properties when parsing the style #8445

Open
asheemmamoowala opened this issue Jul 8, 2019 · 0 comments
Open

De-duplicate array enums for symbol layer properties when parsing the style #8445

asheemmamoowala opened this issue Jul 8, 2019 · 0 comments
Labels
api 📝 refactoring 🏗️

Comments

@asheemmamoowala
Copy link
Contributor

asheemmamoowala commented Jul 8, 2019 •
edited
Loading

Moved from #8399 (comment)

text-variable-anchor values are not currently de-duped.
In #8399, text-writing-mode values are de-duped for every bucket.

The array of values for text-variable-anchor and text-writing-mode should be de-duplicated as part of parsing the style. This would do it just once, allow better style diffing, and reduce per-bucket work.
@asheemmamoowala asheemmamoowala mentioned this issue Jul 8, 2019
Merged
6 tasks
@asheemmamoowala asheemmamoowala mentioned this issue Jul 15, 2019
Merged
5 tasks
@asheemmamoowala asheemmamoowala added this to the release-queso milestone Jul 19, 2019
@chloekraw chloekraw mentioned this issue Aug 5, 2019
Open
@chloekraw chloekraw modified the milestones: release-r, release-queso Aug 13, 2019
@asheemmamoowala asheemmamoowala removed this from the release-t milestone Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api 📝 refactoring 🏗️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mourner @vakila @asheemmamoowala @chloekraw