Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geolocation error handling not working #8870

Closed
kilianso opened this issue Oct 14, 2019 · 1 comment · Fixed by #8871
Closed

geolocation error handling not working #8870

kilianso opened this issue Oct 14, 2019 · 1 comment · Fixed by #8871

Comments

@kilianso
Copy link

Geolocation error handling is not working.

mapbox-gl-js version: 1.4.1

browser: Safari 13.0.2 on Mac OS Mojave

Steps to Trigger Behavior

  1. Disable location service in system settings.
  2. Open example below and try to locate user by clicking the geolocation control.

Link to Demonstration

Locate User Example

Expected Behavior

  1. If user clicks on "do not allow", control should be visually updated to indicate that it is not possible to set the location.
  2. If user has disabled overall location services in system settings of Mac OS, there needs to be a message or visual indicator that mapbox control will not work.

Actual Behavior

  1. If user clicks on "do not allow" – control appearance is not updated.
  2. If user has disabled the overall location services in system settings of Mac OS – there is no notification, or any other indicator, that the mapbox control for geolocation is not working.
@kkaefer
Copy link
Contributor

kkaefer commented Oct 15, 2019

@kilianso you can test the PR in #8871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants