Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documentation of deprecated filter syntax #9227

Closed
stevage opened this issue Jan 23, 2020 · 2 comments
Closed

Remove documentation of deprecated filter syntax #9227

stevage opened this issue Jan 23, 2020 · 2 comments

Comments

@stevage
Copy link
Contributor

stevage commented Jan 23, 2020

Now that there is the new in expression, everything that was possible with the old filter syntax is now easily possible with expressions, simply by replacing key with ["get", key]. (Except "none" which is just ["!", ["any", ...]]

So, perhaps time to completely remove it from the mapbox-gl documentation site. (Or move it to some other dumping ground...)

A few reasons to get rid of the documentation for the old filter syntax:

  1. To stop new people adopting it, and hence smoothing the path to dropping support for it totally.
  2. To make navigating the documentation easier, and avoid accidentally reading the wrong thing. (This happens to me fairly often).

Although I kind of miss the simpler syntax, the similarity with the new syntax (yet total lack of compatibility between) is really problematic at times.

(From #9222)

@ryanhamley
Copy link
Contributor

@stevage I have some good news for you. The @mapbox/docs team just pushed an update to our docs site which largely solves this problem (I promise I didn't know about this an hour ago when I asked you to make this issue!).

The filter docs are now hidden in a dropdown menu under the Other header which is clearly marked as Legacy.

Screen Shot 2020-01-23 at 2 47 00 PM

Additionally, the docs are now broken up into individual pages so there's no confusion between expressions and filters when searching the page for e.g. "in". Sorry to have you open a new issue unnecessarily but at least this problem is solved.

@stevage
Copy link
Contributor Author

stevage commented Jan 24, 2020

Wow, that's excellent! Such timing - life is weird like that sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants