Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add ability for cameraForShape to fix the pitch #10115

Closed
asheemmamoowala opened this issue Oct 3, 2017 · 4 comments
Closed

Add ability for cameraForShape to fix the pitch #10115

asheemmamoowala opened this issue Oct 3, 2017 · 4 comments
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl navigation For the Mapbox Navigation SDK for Android or iOS or navigation use cases in general

Comments

@asheemmamoowala
Copy link
Contributor

asheemmamoowala commented Oct 3, 2017 •
edited
Loading

This is a follow-up to #9809 and depends on #2259.

Map::cameraForLatLngs should provide an overload where an arbitrary pitch can be provided for fitting a shape.
@asheemmamoowala asheemmamoowala added the Core The cross-platform C++ core, aka mbgl label Oct 3, 2017
@asheemmamoowala asheemmamoowala mentioned this issue Oct 3, 2017
Merged
@asheemmamoowala asheemmamoowala changed the title Fit camera to shape correctly for pitched views Add ability for cameraForShape to fix the pitch Oct 4, 2017
@1ec5 1ec5 mentioned this issue Mar 6, 2018
Closed
@1ec5 1ec5 added the navigation For the Mapbox Navigation SDK for Android or iOS or navigation use cases in general label Mar 6, 2018
@1ec5
Copy link
Contributor

1ec5 commented Jun 27, 2018

This feature is being implemented in #12213.

@asheemmamoowala
Copy link
Contributor Author

@1ec5 #12213 doesn't implement correctness when pitch is set to a non-zero value. Lets leave this open to implement pitch-aware fitting.

@d-prukop
Copy link
Contributor

d-prukop commented Oct 2, 2018

@asheemmamoowala see #13007

@1ec5 1ec5 mentioned this issue Oct 3, 2018
Closed
@d-prukop d-prukop mentioned this issue Oct 3, 2018
Closed
@stale stale bot added the archived Archived because of inactivity label Mar 31, 2019
@stale
Copy link

stale bot commented Apr 1, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl navigation For the Mapbox Navigation SDK for Android or iOS or navigation use cases in general
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@1ec5 @asheemmamoowala @d-prukop