What is MultiPoint

[tmcw]

Something seems off about this

https://github.com/mapbox/mapbox-gl-native/blob/master/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/annotations/MultiPoint.java

• The docs refer to it as being a 'polyline'
• There's a MultiPoint.java, but not a Point.java
• Besides geometry, it also manages alpha, but just alpha.

What's up with this?

[tmcw]

Reading into this, yeah, it's a coordinate-container abstract class that's extended by Polygon and Polyline. That shouldn't be the case, it should be named something else and more obviously documented.

Also maybe it should be protected?

[tobrun]

@tmcw

The docs refer to it as being a 'polyline'

Can you show me what you which docs you are referring to?

it's a coordinate-container abstract class that's extended by Polygon and Polyline.

Where are you reading this?
this is currently not part of the javadoc (I created #3338 to improve this).

I must admit that I'm also not 💯 on current naming and inheritance.

cc @bleege @zugaldia

[tmcw]

It's referred to as a polyline here: https://github.com/mapbox/mapbox-gl-native/blob/master/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/annotations/MultiPoint.java#L28

It's extended at https://github.com/mapbox/mapbox-gl-native/blob/master/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/annotations/Polyline.java and https://github.com/mapbox/mapbox-gl-native/blob/master/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/annotations/Polygon.java

There's isn't necessarily a logic problem here, but the usage of MultiPoint really conflicts with its usage elsewhere, in the Simple Features Spec, GeoJSON, and other geo standards.

[tobrun]

@tmcw
Current gameplan is to refactor annotations with the 4.0.0 release.

I'm looking into the possibility to:

• remove Multipoint & Annotation base classes (not that logical)
• remove Icon and Iconfactory (obsolete, not needed)
• streamline with requirements coming from geo standards

[zugaldia]

@tmcw After releasing the directions and geocoder libraries we've noticed that there's some work we need to do to streamline our geographic data structures. See for example the unnecessary conversion we need to do in this example from List<Waypoint> into LatLng[] (not to mention that Android has its own Location object).

I want to put some effort into fixing this and I'd love your feedback. What would be in your opinion the best approach here? Would be using the GeoJSON standard as our objects building block the way to go?

[zugaldia]

Related: #3630

[1ec5]

The iOS and OS X SDKs have a similar class naming issue, captured in #5201.

[tobrun]

This change didn't land with 4.0.0, we need to look into with next semver-major release

[ivovandongen]

Removed the current milestone as this requires breaking changes to the api