Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Make location provider library dependency optional #9403

Closed
zugaldia opened this issue Jun 30, 2017 · 0 comments
Closed

Make location provider library dependency optional #9403

zugaldia opened this issue Jun 30, 2017 · 0 comments
Assignees
Labels
Android Mapbox Maps SDK for Android beta blocker Blocks the next beta release

Comments

@zugaldia
Copy link
Member

Building upon the flexibility brought by mapbox/mapbox-java#269 and #8668, we'd like to make LOST a provided (optional) dependency. This enables developers to rely on core Android location services or to use Google Play Services without having to bundle unused dependencies.

This change brings additional benefits:

  1. It reduces the default dependencies (size and method count) bundled with the SDK
  2. Developers can set their own library versions and work around any issues present on those libraries.

The proposed approach is:

  • Bundle default LocationEngine implementations for Android core, LOST, and Google Play Services backends
  • Add LOST and Google Play Services to build.gradle as optional dependencies
  • At runtime, detect whether LOST or Google Play Services are available
  • Let the developer set a priority preference for location provider backend

@mapbox/android Any thoughts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android beta blocker Blocks the next beta release
Projects
None yet
Development

No branches or pull requests

3 participants