Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strokeWidth is ignored in StaticPolylineAnnotation (in the url function) #851

Closed
1 of 3 tasks
jglanz opened this issue Jul 18, 2018 · 1 comment · Fixed by #855
Closed
1 of 3 tasks

strokeWidth is ignored in StaticPolylineAnnotation (in the url function) #851

jglanz opened this issue Jul 18, 2018 · 1 comment · Fixed by #855

Comments

@jglanz
Copy link

jglanz commented Jul 18, 2018

WHat kind of issue is this?

  • Questions are better to ask on Stack Overflow. We are actively monitoring the questions there and oftentimes, others have already asked a similar question.
  • Feature request should start off by describing the problem the feature will resolve. Please open a GitHub ticket beforehand with information about the feature to spark some discussion about the topic and once you have our support.
  • Bug Report can be reported using the provided template below:
/**
   * <em>Used Internally.</em>
   *
   * @return a String representing the marker part of the URL.
   * @since 2.1.0
   */
  @RestrictTo(LIBRARY)
  public String url() {
    StringBuilder sb = new StringBuilder();

    sb.append("path");
    if (strokeWidth() != null) {
      sb.append("-").append(strokeColor()); // SHOULD BE WIDTH
    }
    if (strokeColor() != null) {
      sb.append("+").append(strokeColor());
    }
    if (strokeOpacity() != null) {
      sb.append("-").append(strokeOpacity());
    }
    if (fillColor() != null) {
      sb.append("+").append(fillColor());
    }
    if (fillOpacity() != null) {
      sb.append("-").append(fillOpacity());
    }
    sb.append("(").append(polyline()).append(")");
    return sb.toString();
  }

Expected Behavior

stroke width to work

Current Behavior

stroke width doesn't work

Possible Solution

fix the function i pasted directly from the mapbox codebase

Steps to Reproduce

look at code above

Context (Environment)

android

Detailed Description

look at code above

Possible Implementation

look at code above

@osana
Copy link
Contributor

osana commented Jul 24, 2018

@jglanz Thank you for reporting this. I am adding tests for this as well.

@osana osana closed this as completed in #855 Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants