Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigator Module changelog #1943

Closed
msh91 opened this issue May 21, 2019 · 6 comments
Closed

Navigator Module changelog #1943

msh91 opened this issue May 21, 2019 · 6 comments

Comments

@msh91
Copy link

msh91 commented May 21, 2019

Hi,
Is there any documentation or changelog for Navigator module?

@msh91
Copy link
Author

msh91 commented Jun 23, 2019

anything news here?

@Guardiola31337
Copy link
Contributor

Hey @msh91 👋 thanks for reaching out and report your question.

Overall, the shared Navigator library and functionality added in #1265 serves to bring many improvements to our core routing / processing logic. Its core functionality is written in C++ similar to our Maps SDK, which provides major performance enhancements.

Outside of performance and reliability, it makes it much easier to align platforms (iOS v. Android for example), where previously we were in a constant state of flux for platform parity.

In general, it should be transparent to developers (as it's an internal cross platform library used by the SDKs which implements some core features) but what are you missing exactly?

@msh91
Copy link
Author

msh91 commented Jul 22, 2019

Hey @Guardiola31337 thanks for the response.
I just wanted to know what's happening in that module :)
As far as I understand from the source code, the Navigator module performs 2 main jobs: offline routing and processing current navigation status.
We don't need the first part, offline routing algorithms, because we have our own implementation of it. All we want to do is to change and customize NavigationStatus but we cannot do it because the Navigator module is closed-source! and also the Navigator class in that module is final so we cannot even extend it to have our own implementation. For these reasons, this project, Mapbox Navigation, is not open source anymore.
I think it would be great if these 2 different parts were 2 different modules with different accessibility rules.

@haibthe
Copy link

haibthe commented Apr 17, 2020

Hey @msh91, I parse DirectionsRoute from json string, after to launcher Navigation with simluator. But Fakelocation was running, instruction not changed. When I debug source in RouteProcessorRunnable, in process() NavigationStatus status = mapboxNavigator.retrieveStatus(date,
options.navigationLocationEngineIntervalLagInMilliseconds());

status -> INVALID. I don't know this reason.

@msh91
Copy link
Author

msh91 commented Apr 18, 2020

Hi @haibthe, I think you should ask @Guardiola31337 for further information.

@haibthe
Copy link

haibthe commented Apr 18, 2020

Hi @msh91 , @Guardiola31337 , I fix that bug, DirectionsRoute's json don't have intersections field. Thanks you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants