Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should see themselves progress through tunnel when GPS is weak or nonexistent #835

Closed
4 of 6 tasks
akitchen opened this issue Apr 6, 2018 · 3 comments
Closed
4 of 6 tasks
Assignees
Labels
feature New feature request. platform parity Required to keep on par with iOS.
Milestone

Comments

@akitchen
Copy link

akitchen commented Apr 6, 2018

Goal: relative feature parity w/iOS:

  • Night mode when entering a tunnel (based on road segment attributes)
  • Continuing simulated progress along route if lack of decent GPS
  • Switching back to appropriate Day/Night mode when exiting tunnel (i.e. at night we would still be in night mode)

Look for opportunities to deliver incrementally in smaller pieces. Consider multiple PRs or a larger PR which we merge more than once.

Things to do:

  • Evaluate inTunnel value of NavigationStatus response object
  • Include an option in NavigationUIOptions to allow developers to conditionally control tunnel mode
    • Requires exposing a callback to notify upon entering/exiting a tunnel

See #1392 (comment) for further details on why ☝️ is not needed anymore

This landed as part of #1336 and #1354

@akitchen akitchen changed the title **User should see themselves progress through tunnel when GPS is weak or nonexistent** User should see themselves progress through tunnel when GPS is weak or nonexistent Apr 6, 2018
@akitchen akitchen added feature New feature request. size: L platform parity Required to keep on par with iOS. labels Apr 6, 2018
@akitchen
Copy link
Author

Updated/groomed OP with @Guardiola31337 in order to keep up-to-date

1 similar comment
@akitchen
Copy link
Author

akitchen commented Sep 7, 2018

Updated/groomed OP with @Guardiola31337 in order to keep up-to-date

@danesfeder
Copy link
Contributor

danesfeder commented Sep 7, 2018

pass future date into navigator to retrieve projected position

Noting here that this is no longer how the Navigator#getStatus API is setup - we can continually pass in the current date/time in a loop and Navigator will begin to provide projected latlngs if we stop providing FixLocation updates via Navigator#updateLocation

@akitchen akitchen added this to the 0.22.0 milestone Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request. platform parity Required to keep on par with iOS.
Projects
None yet
Development

No branches or pull requests

3 participants