Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from JS to TS #4

Closed
ianthetechie opened this issue Dec 5, 2022 · 3 comments · Fixed by #52
Closed

Migrate from JS to TS #4

ianthetechie opened this issue Dec 5, 2022 · 3 comments · Fixed by #52
Labels
help wanted Extra attention is needed

Comments

@ianthetechie
Copy link
Collaborator

RN appears to use a method of runtime type check enforcement, which is essentially deprecated and becomes unnecessary when using TypeScript. See facebook/react-native#33557 for context.

This should ultimately enable us to remove both the duplicated peer+dev dependency on prop-types (to get unit tests passing) and let us ditch deprecated-react-native-prop-types, which FB added as a stop gap for JS projects and I presume is very much deprecated ;)
@ianthetechie ianthetechie added the help wanted Extra attention is needed label Dec 20, 2022
@sarahsporck
Copy link
Collaborator

Is someon currently already working on this? I'm free to do some stuff :)

@sarahsporck
Copy link
Collaborator

So I'm currently working on this, so feel free to look forward to awesome ts types 😎

@ianthetechie
Copy link
Collaborator Author

Great to hear @sarahsporck!

@sarahsporck sarahsporck mentioned this issue Aug 17, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Js to ts sarahsporck/maplibre-react-native
2 participants
@ianthetechie @sarahsporck