Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure prefix maps is a true bimap #469

Closed
matentzn opened this issue Nov 20, 2023 · 2 comments
Closed

Ensure prefix maps is a true bimap #469

matentzn opened this issue Nov 20, 2023 · 2 comments
Assignees
@hrshdhgd

Comments

@matentzn
Copy link
Collaborator

matentzn commented Nov 20, 2023 •
edited
Loading

In the latest release (not necessarily on master, have not checked), duplicate URI prefixes may enter. Write a test that ensures that when an external prefixmap is passed in during parse that overlaps with the internal prefix map, that not both get serialised:

#   Orphanet: http://www.orpha.net/ORDO/Orphanet_
#   orphanet.ordo: http://www.orpha.net/ORDO/Orphanet_
@matentzn matentzn mentioned this issue Nov 20, 2023
Merged
@cthoyt
Copy link
Member

cthoyt commented Nov 20, 2023

Related: biopragmatics/bioregistry#969

This was referenced Nov 24, 2023
Closed
Open
@hrshdhgd hrshdhgd mentioned this issue Nov 27, 2023
Closed
@matentzn
Copy link
Collaborator Author

matentzn commented Dec 5, 2023

No longer relevant!

@matentzn matentzn closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hrshdhgd hrshdhgd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefixes should be checked against .bimap instead of .prefix_map mapping-commons/sssom-py
3 participants
@cthoyt @hrshdhgd @matentzn