Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color for BulkUpdateButton #7296

Closed
friday opened this issue Feb 24, 2022 · 2 comments · Fixed by #7303
Closed

Fix color for BulkUpdateButton #7296

friday opened this issue Feb 24, 2022 · 2 comments · Fixed by #7303
Labels

Comments

@friday
Copy link
Contributor

friday commented Feb 24, 2022

It uses the theme's error color, because it was accidentally copied from BulkDeleteButton

To fix this you need to remove this, or change the error color to primary (maybe the latter, so user can override it?):

const useStyles = makeStyles(
theme => ({
updateButton: {
color: theme.palette.error.main,
'&:hover': {
backgroundColor: alpha(theme.palette.error.main, 0.12),
// Reset on mouse devices
'@media (hover: none)': {
backgroundColor: 'transparent',
},
},
},
}),
{ name: 'RaBulkUpdateWithUndoButton' }
);

@djhi
Copy link
Contributor

djhi commented Feb 24, 2022

Thanks for the report. Would you mind opening a pull request to fix this?

@djhi djhi added the bug label Feb 24, 2022
@friday
Copy link
Contributor Author

friday commented Feb 24, 2022

Thanks for the report. Would you mind opening a pull request to fix this?

I don't have enough time to figure out how your dev setup with monorepo etc works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants