Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Feed import progress bar is misleading #379

Closed
Randl opened this issue Mar 10, 2021 · 1 comment
Closed

[BUG]: Feed import progress bar is misleading #379

Randl opened this issue Mar 10, 2021 · 1 comment
Assignees
Labels
Status-Duplicate Ticket for this stuff already exists and/or requested changes are already implemented. Type-Defect This is BUG!!!
Milestone

Comments

@Randl
Copy link

Randl commented Mar 10, 2021

Brief description of the issue.

The progress bar for import can jump backward during importing.

How to reproduce the bug?

  1. Import an opml backup
  2. Watch the progressbar

What was the expected result?

Progressbar always increases and estimates time left well.

What actually happened?

Progressbar may jump backward. From what I understand it happens since only direct children of processed nodes are counted to estimate total number of feeds (

). If feeds are all categorized, this is very inaccurate. Instead, counting all nodes before start may be more accurate even thought it'd require traverse the tree twice.

Other information

  • OS: macOS Big Sur 11.2.1
  • Desktop Environment:
  • RSS Guard version: 3.9.0
@Randl Randl added the Type-Defect This is BUG!!! label Mar 10, 2021
@martinrotter
Copy link
Owner

Hello @Randl, I identified the same problem some days ago and have already fixed it.

808089d

@martinrotter martinrotter added the Status-Duplicate Ticket for this stuff already exists and/or requested changes are already implemented. label Mar 10, 2021
@martinrotter martinrotter added this to the 4.0.0 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status-Duplicate Ticket for this stuff already exists and/or requested changes are already implemented. Type-Defect This is BUG!!!
Projects
None yet
Development

No branches or pull requests

2 participants