Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Article List Row Height #528

Closed
qcybb opened this issue Nov 1, 2021 · 9 comments
Closed

[BUG]: Article List Row Height #528

qcybb opened this issue Nov 1, 2021 · 9 comments

Comments

@qcybb
Copy link

qcybb commented Nov 1, 2021

Brief description of the issue

Setting the value to anything but -1, 0 or 1 shrinks the font size down to an unreadable size.

It also does not adjust the row spacing between news entries which I am looking to do.

Maybe I'm understanding the option correctly?

How to reproduce the bug?

Adjust the "Article List Row Height" setting to anything but 1, 0 or 1.

What was the expected result?

Adjust the row spacing between news entries

What actually happened?

Shrink the font size down to an unreadable size and does not adjust the row spacing between news entries.

Other information

No response

Operating system and version

  • OS: Windows 10 Home
  • RSS Guard version: 4.04

rssguard

@qcybb qcybb added the Type-Defect This is BUG!!! label Nov 1, 2021
@akinokonomi
Copy link
Collaborator

akinokonomi commented Nov 1, 2021

Adjust the "Article List Row Height" setting to anything but 1, 0 or 1.

What values did you try to set it to exactly?

E.g. 30 (on Linux):
image

40
image

@qcybb
Copy link
Author

qcybb commented Nov 1, 2021

I tried 0-12 and then stopped. I guess I misunderstood the option and what it did.

Is there an option to increase the spacing between rows? They are too close together.

@martinrotter
Copy link
Owner

martinrotter commented Nov 2, 2021

I tried 0-12 and then stopped. I guess I misunderstood the option and what it did.

Is there an option to increase the spacing between rows? They are too close together.

It seems like a bug. There are two options:

Article list row height which should set height of each row i pixels.

Article list font where you can set font type/size.

Using those two features you should be set the list size exactly, including padding etc.

Let me check. Also, try to use both options, for example set bigger height (for example 25) and also adjust the font. It should just work.

@martinrotter
Copy link
Owner

Found a bug, fixing.

@martinrotter
Copy link
Owner

image

Fixed, now, both settings mentioned above do actually work well together. You can set your row height for example to 20 and font size to 15 to create padding. See screenshot with both lists row heights and fonts customized.

@martinrotter
Copy link
Owner

71dd65a

@akinokonomi
Copy link
Collaborator

71dd65a

Can confirm. "Article List Row Height" works only for line height now.

@martinrotter
Copy link
Owner

@akinokonomi Wait so you say issue is not solved? I do not entirely understand what you try to say.

@akinokonomi
Copy link
Collaborator

For me (Arch Linux), when I changed the value of "Article list row height" the font size would also change.
So no, now it works right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants