Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Henry/87958/feat add all rates dropdown accumulator #88

Closed
wants to merge 4 commits into from
Closed

Henry/87958/feat add all rates dropdown accumulator #88

wants to merge 4 commits into from

Conversation

henry-deriv
Copy link
Collaborator

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@henry-deriv henry-deriv changed the base branch from master to maryia/67492/task_add_accumulators February 16, 2023 07:36
maryia-deriv pushed a commit that referenced this pull request Jun 12, 2023
@jim-deriv @hamza-deriv
Jim | Hamza/88557/replace-connect-with-use-store-trader-parent (binar…
a431f4c 
…y-com#8270)

* chore: add useTraderStores

* chore: add trader-providers

* refactor: replace MobxContentProvider with TraderProviders

* chore: update trader to trade

* refactor: replace connect in Trader package v1.0 (#76)

* refactor: contract-replay, contract-drawer and contract-drawer-card to use useStore (#77)

* Jim/93585/replace connect with usestore in market countdown timer market unavailable trade modals unsupported contract modal (#79)

* refactor: remove connect from market-countdown-timer

* refactor: remove connect from market-unavailable

* refactor: remove connect from trade-modals

* refactor: move is_visible prop to market-unavailable

* refactor: remove connect from unsupported-contract-modal

* Hamza/93474/replace connect with use trader store (#78)

* refactor: replace connect in Trader package v1.0

* refactor: replace connect with useTraderStore v1.2

* refactor: replace connect with useTraderStore v1.2.1

* refactor: replace connect with useTraderStore v1.2.2

* refactor: replace connect with useTraderStore v1.2.3

* Hamza/93474/replace connect with use trader store (#80)

* refactor: replace connect in Trader package v1.0

* refactor: replace connect with useTraderStore v1.2

* refactor: replace connect with useTraderStore v1.2.1

* refactor: replace connect with useTraderStore v1.2.2

* refactor: replace connect with useTraderStore v1.2.3

* refactor: replace connect with useTraderStore v1.3

* refactor: replace connect with useTraderStore v1.4

* Jim/93604/replace connect with use store in positions drawer positions modal card toggle positions mobile time picker populate header (#81)

* refactor: remove connect from positions-drawer

* refactor: remove connect from positions-modal-card

* refactor: remove connect from toggle-positions-mobile

* refactor: remove connect from time-picker

* refactor: remove connect from populate-header

* Jim/93667/replace connect with use store in trade header extensions trade settings extensions progress slider stream routes (#83)

* refactor: remove connect from positions-drawer

* refactor: remove connect from positions-modal-card

* refactor: remove connect from toggle-positions-mobile

* refactor: remove connect from time-picker

* refactor: remove connect from populate-header

* refactor: remove connect from trade-footer-extensions

* refactor: migrate trade-header-extensions to ts and remove connect from it

* refactor: migrate trade-settings-extensions to ts and remove connect from it

* refactor: remove connect from progress-slider-stream and routes

* chore: update mocstore with new fields

* Hamza/93474/replace connect with use trader store (#82)

* refactor: replace connect in Trader package v1.0

* refactor: replace connect with useTraderStore v1.2

* refactor: replace connect with useTraderStore v1.2.1

* refactor: replace connect with useTraderStore v1.2.2

* refactor: replace connect with useTraderStore v1.2.3

* refactor: replace connect with useTraderStore v1.3

* refactor: replace connect with useTraderStore v1.4

* refactor: replace connect with useTraderStore v1.5

* refactor: replace connect with useTraderStore v1.5.1

* refactor: replace connect with useTraderStore v1.5.2

* refactor: replace connect with useTraderStore v1.5.3 test failing fixed

* refactor: replace connect with useTraderStore v1.5.4

* Jim/88556/replace connect with use store in settings chart accumulators stats contract replay widget contract and toolbar widgets (#84)

* chore: removeconnectsettings-chart/accumulators-stats/contract-replay-widget/contracttoolbar-widgets

* refactor: remove connect from accumulators-stats.spec

* refactor: replace connect in top-widgets_cancel-deal-mobile_risk-management-info_mobile-widget

* Hamza/93474/replace connect with use trader store (#85)

* refactor: replace connect in Trader package v1.0

* refactor: replace connect with useTraderStore v1.2

* refactor: replace connect with useTraderStore v1.2.1

* refactor: replace connect with useTraderStore v1.2.2

* refactor: replace connect with useTraderStore v1.2.3

* refactor: replace connect with useTraderStore v1.3

* refactor: replace connect with useTraderStore v1.4

* refactor: replace connect with useTraderStore v1.5

* refactor: replace connect with useTraderStore v1.5.1

* refactor: replace connect with useTraderStore v1.5.2

* refactor: replace connect with useTraderStore v1.5.3 test failing fixed

* refactor: replace connect with useTraderStore v1.5.4

* refactor: replace the connect with useStore v1.6

* fix: reverted the duration-wrapper

* fix: the duration-wrapper

* refactor: replace connect in top-widgets_cancel-deal-mobile_risk-management-info_mobile-widget (#86)

* refactor: restore component structure to its original form

* refactor: remove MobxContentProvider

* refactor: replace connect in strike, vanilla-trade-type, screen-small, chart-widgets, and test

* Jim/93866/replace_connect_with_usestore_in_strike_vanilla-trade-type_screen-small_chart-widgets_and_test (#87)

* refactor: replace connect in top-widgets_cancel-deal-mobile_risk-management-info_mobile-widget

* refactor: restore component structure to its original form

* refactor: remove MobxContentProvider

* refactor: replace connect in strike, vanilla-trade-type, screen-small, chart-widgets, and test

* Hamza/93474/replace connect with use trader store (#88)

* refactor: replace connect in Trader package v1.0

* refactor: replace connect with useTraderStore v1.2

* refactor: replace connect with useTraderStore v1.2.1

* refactor: replace connect with useTraderStore v1.2.2

* refactor: replace connect with useTraderStore v1.2.3

* refactor: replace connect with useTraderStore v1.3

* refactor: replace connect with useTraderStore v1.4

* refactor: replace connect with useTraderStore v1.5

* refactor: replace connect with useTraderStore v1.5.1

* refactor: replace connect with useTraderStore v1.5.2

* refactor: replace connect with useTraderStore v1.5.3 test failing fixed

* refactor: replace connect with useTraderStore v1.5.4

* refactor: replace the connect with useStore v1.6

* fix: reverted the duration-wrapper

* fix: the duration-wrapper

* fix: contract not bought error config missing from props

* refactor: remove connect function definition and connectwithcontractupdates

* Jim/93908/remove-connect-and-connect-with-contract-updates-definitions from trader (#89)

* refactor: replace connect in top-widgets_cancel-deal-mobile_risk-management-info_mobile-widget

* refactor: restore component structure to its original form

* refactor: remove MobxContentProvider

* refactor: replace connect in strike, vanilla-trade-type, screen-small, chart-widgets, and test

* refactor: remove connect function definition and connectwithcontractupdates

* refactor: address whitespace comments, type exportsclear

* chore: remove unused invalid import

* chore: add type keyword on import statement

* chore: add whitespace

* refactor: remove passthrough.root_store

* chore: restore props

* chore: remove sonarcloud bug

* refactor: wrap allowequalsmobile in a div to make it collapsible

---------

Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@henry-deriv