Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Detailed description of code example for collapsing toolbar style #3915

Closed
wants to merge 1 commit into from

Conversation

cworld1
Copy link
Contributor

@cworld1 cworld1 commented Dec 9, 2023

I think it is necessary to add the specific topAppBar primary key description code to the code instance of collapsing toolbar style. Although this hint appeared in the normal toolbar style, it wasn't obvious enough that it took me hours to figure out what the problem was. Setting layout_height to another option causes the component to not work properly and the title to not display properly. Hopefully this new description will help others avoid this problem.

Thanks for starting a pull request on Material Components!

Don't forget:

  • Identify the component the PR relates to in brackets in the title.
    [Buttons] Updated documentation
  • Link to GitHub issues it solves. closes #1234
  • Sign the CLA bot. You can do this once the pull request is opened.

Contributing
has more information and tips for a great pull request.

Copy link

google-cla bot commented Dec 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cworld1
Copy link
Contributor Author

cworld1 commented Jan 27, 2024

Emmm... What's wrong about this pr?

hunterstich pushed a commit that referenced this pull request Mar 21, 2024
…toolbar style

Resolves #3915

GIT_ORIGIN_REV_ID=88bb0c690dc9fb8386165acfffcf9d18ae897f1d
PiperOrigin-RevId: 601582020

(cherry picked from commit b80efdd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants