Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When sending to IRC, convert italics to markdown, not control codes #1552

Open
bradyt opened this issue Apr 3, 2022 · 5 comments
Open

When sending to IRC, convert italics to markdown, not control codes #1552

bradyt opened this issue Apr 3, 2022 · 5 comments
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.

Comments

@bradyt
Copy link

bradyt commented Apr 3, 2022

For #emacs:libera.chat, the channel mode contains +c.

c colour filter | Strip colour and formatting codes from channel messages.

-- https://libera.chat/guides/channelmodes

Currently, user does not have an easy way in desktop Element to always rely on message being sent as plain text. See element-hq/element-web#20321 (comment).

Underscores are silently converted to html italics, > a quote is silently converted to blockquote html. IRC bridge silently converts these to control codes or ASCII text, the Element/Matrix user is not aware of this. If the IRC channel silently drops control codes, but not the > character, user may not be aware of what actually is received at other end. This can be unfortunate if these characters are part of a syntax under discussion on IRC channel, or is being used to interact with a channel bot.

In particular, _underscored text_ is silently received as underscored text on +c channels.

As long as Element, arguably the flagship Matrix client, is not facilitating sending non-html text converted from markdown, I would suggest that italics and bold text are not converted to control codes by IRC bridge.

I understand the likelihood that this project will decide to not avoid control codes. I hope such an explicit stance hopes to further motivate the issue at Element for desktop.

@tadzik
Copy link
Contributor

tadzik commented May 16, 2022

Converting to markdown would be a sensible fallback for +c channels, for non-+c I think it makes sense to keep it the way it is.

@tadzik tadzik added S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. labels May 16, 2022
@BrenBarn
Copy link

BrenBarn commented Nov 25, 2022

I just assumed that the bridge would send plaintext only (i.e., send the raw markdown as text). That seems like the most sensible thing. I don't want to assume any capabilities on the primitive IRC end of the bridge. :-)

I don't really understand why the bridge is working with HTML in the first place. Wouldn't the plaintext version of the message be a safer starting point?

@poVoq
Copy link

poVoq commented Jan 24, 2023

A setting to always send raw Markdown would be nice as there are IRC clients that understand it.

@progval
Copy link
Contributor

progval commented Jan 25, 2023

Which ones?

@poVoq
Copy link

poVoq commented Jan 25, 2023

Convos for example and also most XMPP clients connected to IRC channels via Biboumi. But there are probably also others that support basic markdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.
Projects
None yet
Development

No branches or pull requests

5 participants