Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We currently log the access token in multiple places #1110

Closed
jplatte opened this issue Oct 14, 2022 · 0 comments · Fixed by #1117
Closed

We currently log the access token in multiple places #1110

jplatte opened this issue Oct 14, 2022 · 0 comments · Fixed by #1117
Assignees
Labels
bug Something isn't working help wanted Interested in working on the project? These are great additions we'd like to have!

Comments

@jplatte
Copy link
Collaborator

jplatte commented Oct 14, 2022

We really shouldn't. Example from the matrix room, actual token replaced by X:

2022-10-14T20:51:05.184910Z TRACE sync_with_callback{sync_settings=SyncSettings { timeout: 30s, full_state: false }}:sync_with_result_callback{sync_settings=SyncSettings { timeout: 30s, full_state: false }}:sync_once{sync_settings=SyncSettings { timeout: 30s, token: "X", full_state: false }}:handle_sync_response:send_inner{request=Request { user_id: "@twig-bot:gnome.org" } config=None homeserver=None}:send{config=None homeserver="https://gnome.modular.im/" access_token=Some("X") user_id=Some("@twig-bot:gnome.org") server_versions=[V1_0, V1_1, V1_2] request_type="ruma_client_api::profile::get_display_name::v3::Request"}: matrix_sdk::http_client: Sending request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Interested in working on the project? These are great additions we'd like to have!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants