Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mscbot may not start FCP when using @mscbot reviewed #19

Open
anoadragon453 opened this issue Mar 3, 2022 · 0 comments
Open

mscbot may not start FCP when using @mscbot reviewed #19

anoadragon453 opened this issue Mar 3, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@anoadragon453
Copy link
Member

One can use @mscbot reviewed to automatically check the box for themselves in an ongoing FCP status comment. The bot will also unconditionally ignore all comments and comment edits from itself.

When designing the reviewed command, it was incorrectly assumed that updating the status comment would then have the knock-on effect of starting FCP if enough ticks had happened. Instead, the edit is ignored as it comes from the bot.

A fix would simply involve manually calling _process_status_comment_update_with_body below

# Update the status comment
self._post_or_update_status_comment(
voted_members=voted_members, existing_status_comment=status_comment
)

@anoadragon453 anoadragon453 added the bug Something isn't working label Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant