Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCP can be started again after one had successfully completed #32

Open
anoadragon453 opened this issue Feb 10, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@anoadragon453
Copy link
Member

For instance, after an FCP merge is successful and the proposal is accepted, if a user edits the latest FCP proposal comment and there's enough votes, mscbot will start FCP again. (Example).

A fix here would be to ignore edits to FCP comments if the proposed-final-comment-period label is not present.

@anoadragon453 anoadragon453 added the bug Something isn't working label Feb 10, 2023
@anoadragon453
Copy link
Member Author

Another example: matrix-org/matrix-spec-proposals#4126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant