Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

generate_room_entry breaks due to missing create event #11000

Closed
clokep opened this issue Oct 6, 2021 · 3 comments
Closed

generate_room_entry breaks due to missing create event #11000

clokep opened this issue Oct 6, 2021 · 3 comments
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@clokep
Copy link
Member

clokep commented Oct 6, 2021

See https://sentry.matrix.org/sentry/synapse-matrixorg/issues/226318/

There's at least one room on matrix.org (!puCGMpKizEgwloleEe:matrix.org) where the current_state_events for the room is missing the m.room.create event. There is a create event ($155394871468891LqYwt:matrix.org), but it seems to not be in current_state_events (current_state_events consists solely of m.room.member events.)

What we think happened is:

  1. Everyone on matrix.org left the room.
  2. New members joined via it's possible to join an empty room over federation, resulting in a split-brain room #6958

So the room is now in a broken state, we can probably:

  1. Make generate_room_entry more robust (by skipping the room?)
  2. Purge the room
  3. Try to fix the current_state_events for the room

Note that this code seems to affect the room list, as well as listing rooms in groups/communities.

@clokep clokep added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Oct 6, 2021
@clokep
Copy link
Member Author

clokep commented Oct 6, 2021

@richvdh reports that there seems to be ~5000 rooms that might be affected by this.

@DMRobertson
Copy link
Contributor

Sounds like a duplicate of #9330?

@clokep
Copy link
Member Author

clokep commented Mar 15, 2022

Both filed by me, that was silly...

@clokep clokep closed this as completed Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

No branches or pull requests

2 participants