Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Do not allow forking threads for MSC3440 #11175

Closed
clokep opened this issue Oct 25, 2021 · 0 comments · Fixed by #11161
Closed

Do not allow forking threads for MSC3440 #11175

clokep opened this issue Oct 25, 2021 · 0 comments · Fixed by #11161
Assignees
@clokep
Labels
A-Threads Threaded messages T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@clokep
Copy link
Member

clokep commented Oct 25, 2021 •
edited
Loading

MSC3440 needs to be updated, but it will not allow forking of threads (creating a thread from an event already in a thread).

We should restrict this server side (via the C-S API), but clients will also need to handle these "bad" events coming over federation / broken server.

Builds on #11085
@clokep clokep added the A-Threads Threaded messages label Oct 25, 2021
@clokep clokep self-assigned this Oct 25, 2021
@clokep clokep linked a pull request Oct 25, 2021 that will close this issue
Do not allow MSC3440 threads to fork threads #11161
Merged
@erikjohnston erikjohnston added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
A-Threads Threaded messages T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not allow MSC3440 threads to fork threads matrix-org/synapse
2 participants
@clokep @erikjohnston