Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Invalid app_service_config_files should crash Synapse. #15422

Closed
Half-Shot opened this issue Apr 12, 2023 · 1 comment · Fixed by #15425
Closed

Invalid app_service_config_files should crash Synapse. #15422

Half-Shot opened this issue Apr 12, 2023 · 1 comment · Fixed by #15425
Labels
A-Config Configuration, or the documentation thereof S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@Half-Shot
Copy link
Collaborator

Half-Shot commented Apr 12, 2023 •
edited
Loading

A user managed to pass in a string to the app_service_config_files config option (matrix-org/matrix-appservice-irc#1696) and synapse happily "accepted" it with a warning. I think this probably should have crashed Synapse, rather than allowing them to proceed and thinking something might be wrong with the bridge.
@Half-Shot Half-Shot changed the title app_service_config_files Invalid app_service_config_files should crash Synapse. Apr 12, 2023
@Half-Shot Half-Shot mentioned this issue Apr 12, 2023
Merged
@Half-Shot Half-Shot added A-Config Configuration, or the documentation thereof T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. S-Tolerable Minor significance, cosmetic issues, low or no impact to users. labels Apr 12, 2023
@reivilibre
Copy link
Contributor

Seems valid to me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Config Configuration, or the documentation thereof S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw if the appservice config list is the wrong type matrix-org/synapse
2 participants
@Half-Shot @reivilibre