Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Clean-up server_signature_keys and server_keys_json #15463

Open
clokep opened this issue Apr 20, 2023 · 1 comment
Open

Clean-up server_signature_keys and server_keys_json #15463

clokep opened this issue Apr 20, 2023 · 1 comment
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Cleanup Things we want to get rid of, but aren't actively causing pain Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact

Comments

@clokep
Copy link
Member

clokep commented Apr 20, 2023

Follow-up to #15171 / #15417.

These two tables are used by the server key fetching mechanisms, #15171 (comment) has a good summary, but the tl;dr is that server_keys_json seems to be a superset of server_signature_keys (see #15171 (comment)).

Can we remove server_signature_keys completely?

@DMRobertson DMRobertson added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact Z-Cleanup Things we want to get rid of, but aren't actively causing pain labels Apr 24, 2023
@clokep
Copy link
Member Author

clokep commented Sep 5, 2023

#16257 (comment) has some info on the difference between these tables.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Cleanup Things we want to get rid of, but aren't actively causing pain Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact
Projects
None yet
Development

No branches or pull requests

2 participants