Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

redacted #4658

Closed
ghost opened this issue Feb 16, 2019 · 5 comments
Closed

redacted #4658

ghost opened this issue Feb 16, 2019 · 5 comments

Comments

@ghost
Copy link

ghost commented Feb 16, 2019

redacted

@hawkowl
Copy link
Contributor

hawkowl commented Feb 16, 2019

@gerg5c42g542g2c54g52c is this the matrix.org debian package or the Debian-backports one?

@richvdh
Copy link
Member

richvdh commented Feb 21, 2019

This is presumably only true if you have changed macaroon_secret_key or registration_shared_secret?

@richvdh
Copy link
Member

richvdh commented Feb 21, 2019

I'm not really sure what more we can do if you choose to overwrite your config so that synapse can't find its database any more?

@richvdh
Copy link
Member

richvdh commented Feb 22, 2019

Warn of the consequences;

replacing the configuration is done by dpkg - we don't have an opportunity to add a warning.

don't automatically restart synapse and warn about this;

Not restarting synapse on package upgrade would be more surprising to most users; we used to get frequent bug reports about it until this was fixed.

provide the new config, but disabled fe. as homeserver.yaml.dpkg-new;

That would mean that synapse wouldn't work out-of-the-box, which again would be more surprising to most users.

including a sufficient mention of this in docs, something like 'if you want to revert to or use a clean config do this, but note that you'll have downtime and users logged out';

I'm a bit unconvinced that anyone would read any documentation like this.

perhaps provide a current default config somewhere to download

This is #1433, and certainly something I want to address.

or info on how to extract it or just say 'don't do this!'?

I don't really know what you mean by this.

I see that the default behavior is moving the original config to homeserver.yaml.dpkg-old and putting the new one as the default, which is the opposite to what people want. That might be a debian thing though.

It is a debian thing.

Basically, on this, I understand your pain, but it's hard to do much about it.

One thing that I think might help is to suggest that people put config overrides in a file other than homeserver.yaml, so that they are preserved on upgrade.

@neilisfragile
Copy link
Contributor

Okay this is bad situation and I'm sorry you lost your keys - the impact of the log outs will be reduced by features like https://github.com/matrix-org/matrix-doc/blob/55ebf7dc3275822ad0126546baef4b1361418baf/proposals/1466-soft-logout.md

In terms of concrete todos #1433 seems to cover it - I don't think there is much else we can do here. Closing this issue.

@ghost ghost changed the title [debian package] installing package maintainers config results in massive logouts and key loss. redacted Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants