Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity errors from new matrix multiplication methods in LinearAlgebra #16

Closed
andreasnoack opened this issue Aug 28, 2019 · 1 comment

Comments

@andreasnoack
Copy link

The methods in

function mul!(C::Vector{Float64}, A::Matrix{Float64}, B::Vector{Float64}, α::Number, β::Number)
gemm!('N', 'N', convert(Float64, α), A, B, convert(Float64, β), C)
end
function mul!(C::Vector{Float64}, A::Adjoint{Float64, Matrix{Float64}}, B::Vector{Float64}, α::Number, β::Number)
gemm!('C', 'N', convert(Float64, α), A', B, convert(Float64, β), C)
end
need to be behind a conditions similarly to https://github.com/JuliaLinearAlgebra/GenericLinearAlgebra.jl/blob/1ac7a0f83121849efd76715ee85a115047d6468d/src/juliaBLAS.jl#L87 to avoid breakage in the upcoming Julia version 1.3.

@matthieugomez
Copy link
Owner

Solved & tagged a new version. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants