Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/join requests with malformed body #84

Closed
richvdh opened this issue Jul 26, 2022 · 0 comments
Closed

/join requests with malformed body #84

richvdh opened this issue Jul 26, 2022 · 0 comments

Comments

@richvdh
Copy link

richvdh commented Jul 26, 2022

We see lots of this on requests to POST /_matrix/client/r0/join/{roomIdOrAlias} from clients with user-agents like Go-http-client/2.0:

2022-07-26 00:04:32,466 - synapse.http.servlet - 663 - WARNING - POST-1079194 - Unable to parse JSON: Expecting value: line 1 column 1 (char 0) (b'')

... which suggests something is making requests with a malformed (empty?) body. I think many of these requests are coming from projects based on mautrix.

Currently Synapse accepts this, but it's not spec-compliant and we'll be fixing this in Synapse soon: matrix-org/synapse#13388.

Please could you make sure to include (at least) an empty json object in the request body?
@tulir tulir closed this as completed Dec 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @tulir