Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@mdx-js/rollup stops working on Vite v5 #2413

Closed
4 tasks done
JounQin opened this issue Dec 7, 2023 · 13 comments
Closed
4 tasks done

@mdx-js/rollup stops working on Vite v5 #2413

JounQin opened this issue Dec 7, 2023 · 13 comments
Labels
🙊 open/needs-repro This needs a reproduction

Comments

@JounQin
Copy link
Member

JounQin commented Dec 7, 2023

Initial checklist

Affected packages and versions

@mdx-js/rollup

Link to runnable example

https://github.com/un-ts/mono-lib-boilerplate

Steps to reproduce

yarn
yarn dev

Expected behavior

Render page correctly

Actual behavior

image

Runtime

Node v18

Package manager

yarn v4

OS

macOS

Build and bundle tools

Vite

@ChristianMurphy
Copy link
Member

@JounQin sorry you ran into a spot of trouble.
Could you produce a minimal reproducible example?

It works in my testing https://stackblitz.com/edit/vitejs-vite-4txvc5?file=package.json

@ChristianMurphy ChristianMurphy added the 🙊 open/needs-repro This needs a reproduction label Dec 7, 2023
@JounQin
Copy link
Member Author

JounQin commented Dec 7, 2023

@ChristianMurphy
Copy link
Member

@JounQin have you tried reducing the issue? Or using an official release of vite instead of a patched version?
I'm at a conference right now, but if you're stuck I may be able to help you debug your personal project later.

@JounQin
Copy link
Member Author

JounQin commented Dec 7, 2023

@ChristianMurphy The reproduction is tiny.

image

The patch is also tiny for vitejs/vite#15281

image

I do cannot reproduce on stackblitz: https://stackblitz.com/edit/vitejs-vite-mt6zzg?file=vite.config.ts,src%2Fmain.tsx

I'm still trying to add react-router-dom.

@wooorm
Copy link
Member

wooorm commented Dec 7, 2023

Which repo do you mean? I see a link to https://github.com/un-ts/mono-lib-boilerplate which is giant?

@wooorm
Copy link
Member

wooorm commented Dec 7, 2023

From the Vite issue and your patch, it seems a Vite bug?

@JounQin
Copy link
Member Author

JounQin commented Dec 7, 2023

Which repo do you mean? I see a link to un-ts/mono-lib-boilerplate which is giant?

The vite part is only docs folder. Maybe really a Vite bug which does not support nested folder anymore, I'll find out later.

@JounQin JounQin closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
@JounQin
Copy link
Member Author

JounQin commented Dec 7, 2023

I really can't find out what is going on... I changed almost everything on stackblitz just like my mono-lib-boilerplate, but it just works differently...

@ChristianMurphy If you can help to debug when you're free that would be very appreciated.

@ChristianMurphy
Copy link
Member

@JounQin have you tried installing via npm instead of yarn?
My next thought is that resolutions and how the folders are laid out are different between the two.

@JounQin
Copy link
Member Author

JounQin commented Dec 8, 2023

@JounQin have you tried installing via npm instead of yarn? My next thought is that resolutions and how the folders are laid out are different between the two.

Just tried, it didn't help.

@ChristianMurphy
Copy link
Member

@JounQin I see some more changes landed in un-ts/mono-lib-boilerplate are you still having a vite issue? or has it been resolved?

@JounQin
Copy link
Member Author

JounQin commented Dec 21, 2023

Thanks for still remembering this issue, it is indeed an issue from Vite itself.

@JounQin
Copy link
Member Author

JounQin commented Dec 21, 2023

See also vitejs/vite#15286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙊 open/needs-repro This needs a reproduction
Development

No branches or pull requests

3 participants