Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the codebase with newer Elixir features #5

Open
4 tasks
IvanIvanoff opened this issue Apr 19, 2019 · 1 comment
Open
4 tasks

Update the codebase with newer Elixir features #5

IvanIvanoff opened this issue Apr 19, 2019 · 1 comment

Comments

@IvanIvanoff
Copy link

There are quite a few places where the code can be updated. These include new features of Elixir/Erlang, removal of deprecated stuff or rewriting code in a way that aligns with the latest trends.

  • Migrate away from the supervisor/2 and worker/2 functions commit from Supervisor.Spec
  • Use handle_continue/2 in Blogit.Server.init/1, Blogit.Components.Posts.init/1 functions (possible other places, too) instead of sending message with . This avoids a possible race condition
  • Clean the module that has use Application to not have so many functions
  • Add .formatter.exs file and run the formatter
@jdmarshall
Copy link

deps.compile now fails with this code and I'm not even on the latest elixir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants