Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update Go to 1.21, and update relevant pkgs #365

Closed
saurabh100ni opened this issue Sep 12, 2023 · 8 comments
Closed

[chore] update Go to 1.21, and update relevant pkgs #365

saurabh100ni opened this issue Sep 12, 2023 · 8 comments
Labels
good first issue Good for newcomers hacktoberfest Happy contributing! help wanted Extra attention is needed

Comments

@saurabh100ni
Copy link

Desired Behaviour

Need to update Go to 1.21 in go.mod and in Dockerfile, and also Makefile

  • Minor chore on updating meshkit and meshery-adapter-library
@welcome
Copy link

welcome bot commented Sep 12, 2023

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

@Ghat0tkach Ghat0tkach added hacktoberfest Happy contributing! good first issue Good for newcomers help wanted Extra attention is needed labels Sep 12, 2023
@yash37158 yash37158 self-assigned this Sep 13, 2023
@leecalcote
Copy link
Member

@nebula-aac @theBeginner86 we might need to process this post-haste

@AryanSharma9917
Copy link

Hey @yash37158, are you working on this issue?

@yash37158
Copy link
Member

you can go for it @AryanSharma9917

@Ayush9026
Copy link

@yash37158 will i do it .

@yash37158
Copy link
Member

Yes @Ayush9026, you can start working on this

@nebula-aac
Copy link
Contributor

nebula-aac commented Sep 18, 2023

I forgot to mention that this is already done, however there seems to be an indirect package that creeped in that may affect how other adapters build using the latest from meshkit even without a release. I'm researching now.

Here is the PR: #368

Here was the PR at meshery-osm that had a dependency that creeped in which affected the build.

meshery/meshery-osm#265

@yash37158
Copy link
Member

If this issue is already resolved, we can close it. @nebula-aac

@AryanSharma9917 AryanSharma9917 removed their assignment Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Happy contributing! help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants