Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mirrord non-operator targeting path to use ResolvedTarget . #2780

Open
meowjesty opened this issue Sep 25, 2024 · 1 comment
Open

Refactor mirrord non-operator targeting path to use ResolvedTarget . #2780

meowjesty opened this issue Sep 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@meowjesty
Copy link
Member

When #2752 is merged, we should use ResolvedTarget for the mirrord non-operator targeting code. Right now we use an implementation based on the config::Target that roughly does the same thing.

mirrord/mirrord/cli/src/connection.rs

Line 152 in 9e8db2f

let k8s_api = KubernetesAPI::create(config)

@meowjesty meowjesty added the enhancement New feature or request label Sep 25, 2024
@linear Linear
Copy link

linear bot commented Sep 25, 2024

MBE-416 Refactor mirrord non-operator targeting path to use `ResolvedTarget` .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meowjesty