Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove patchesStrategicMerge that is deprecated #355

Open
liornoy opened this issue Jun 6, 2023 · 3 comments
Open

Remove patchesStrategicMerge that is deprecated #355

liornoy opened this issue Jun 6, 2023 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@liornoy
Copy link
Contributor

liornoy commented Jun 6, 2023

We use patchesStrategicMerge in our kustomization yamls under the config dir,
however, since version 5.0.0 this was deprecated and we need to migrate it.
See the following warning message:

# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
@fedepaol
Copy link
Member

fedepaol commented Jun 6, 2023

To be accurate, we don't need to migrate until it's removed and we use a kubectl version that doesn't support it anymore.
@liornoy wanna take this?

@liornoy
Copy link
Contributor Author

liornoy commented Jun 6, 2023

yes, with pleasure.
and you're right. I confused deprecated with removed.

@liornoy
Copy link
Contributor Author

liornoy commented Jun 18, 2023

see my comment here: metallb/frr-k8s#2 (comment)

@fedepaol fedepaol added the help wanted Extra attention is needed label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fedepaol @liornoy