about changing in Use RegisterDirectiveOrder for rate_limit before basic_auth (#59) (ae5d5ea)

[ta2013]

hi @steffenbusch
we have define some snippets of rate limits, and import those snippets at end of block as below. Then with your change, those RL will get effectively with above handle, handle_path blocks or not? Ie:

(snippet_rl){
…
}

site.example.com {
many handle,
handle_path here….

import snippet_rl
import compression
}
thanks.

[steffenbusch]

Hi @ta2013,

have you used order rate_limit <before|after> <another_directive> in the global options of your Caddyfile, or have you used rate_limit within a route block? Unfortunately, your very limited Caddyfile example does not reveal this. If you need a precise answer, you will have to provide your (formatted) Caddyfile in order to see where and within which directives the snippet_rl is used.

In general (maybe this answers your question already):

• If you use rate_limit within a route, then nothing changes for you.
• If you have used order for rate_limit in Caddyfile global options, then nothing changes for you if you have used order rate_limit before basic_auth, as this is now the default if not specified. If you have used order for rate_limit with a different configuration, then you are still overwriting this mentioned default.

Hope this helps.