Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatadogMeterRegistry: add support for publishing distributions #3243

Closed
monosoul opened this issue Jun 22, 2022 · 4 comments
Closed

DatadogMeterRegistry: add support for publishing distributions #3243

monosoul opened this issue Jun 22, 2022 · 4 comments
Labels
duplicate A duplicate of another issue

Comments

@monosoul
Copy link
Contributor

Please describe the feature request.
At the moment DatadogMeterRegistry doesn't support publishing percentile histogram, while DD's API seems to support publishing distributions already: https://docs.datadoghq.com/api/latest/metrics/#submit-distribution-points .

Rationale
For DatadogMeterRegistry to reach feature parity with the statsd registry

@shakuzen shakuzen added enhancement A general enhancement registry: datadog A Datadog Registry related issue labels Jun 23, 2022
@shakuzen
Copy link
Member

Thanks for letting us know an HTTP API is available for sending distributions now. We previously abandoned efforts to support this with the Datadog registry due to the lack of API. I do still have concerns about how we could/should best handle such a feature. See my previous comment on it #1056 (comment). Unlike the statsd registry, the datadog registry is a step meter registry, which pushes metrics at step intervals. However, to send the raw data that datadog expects for distributions, we would need to either separately publish distribution data in near-realtime with recording or buffer the raw data for publishing. This would add significant complexity. It may still be worth adding if it provides enough value for users.

@shakuzen shakuzen added the internal An issue that needs input from a member on another Team label Jun 23, 2022
@monosoul
Copy link
Contributor Author

Tbh I personally prefer using DatadogMeterRegistry to statsd registry because it has one less point of failure. If something doesn't work with statsd then we have to troubleshoot: the app itself, dogstatsd daemon, the channel between the app and the daemon and the channel between the daemon and DD's API. With DatadogMeterRegistry it's just the app, DD's API and the channel between them.

@shakuzen shakuzen added duplicate A duplicate of another issue and removed enhancement A general enhancement registry: datadog A Datadog Registry related issue internal An issue that needs input from a member on another Team labels Aug 5, 2022
@shakuzen
Copy link
Member

shakuzen commented Aug 5, 2022

I realize we already had an open issue for this: #773. I'll close this as a duplicate of the older issue to keep things in one place.

@shakuzen
Copy link
Member

shakuzen commented Aug 5, 2022

Duplicate of #773

@shakuzen shakuzen marked this as a duplicate of #773 Aug 5, 2022
@shakuzen shakuzen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

2 participants