Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwsApiProxyTestServer doesn't close the web server handler's context and leaks connections #2101

Open
dbmeneses opened this issue Apr 2, 2024 · 2 comments

Comments

@dbmeneses
Copy link

Expected Behavior

When AwsApiProxyTestServer is closed, it should release all of its resources.

Actual Behaviour

AwsApiProxyTestServer creates a custom Jetty web server handler AwsProxyHandler. This handler has its own application context. AwsApiProxyTestServer never calls AwsProxyHandler.destroy(), so the application context is never stopped. Since the application context will typically contain a data source, we also have leaked DB connections as a result.

Steps To Reproduce

No response

Environment Information

No response

Example Application

No response

Version

4.3.2

@sdelamo
Copy link
Contributor

sdelamo commented Apr 12, 2024

do you have a sample application @dbmeneses ?

@dbmeneses
Copy link
Author

I don't, but I'll try to provide one next week.

@timyates timyates removed their assignment May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants