Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation logging level ignored #1415

Closed
multicaststorm opened this issue Dec 17, 2020 · 2 comments · Fixed by #1416
Closed

Instrumentation logging level ignored #1415

multicaststorm opened this issue Dec 17, 2020 · 2 comments · Fixed by #1416

Comments

@multicaststorm
Copy link

Expected behavior

When set the following in applicationinsights.json, I expect to turn off auto log collection (JUL in my case):

{
  "instrumentation": {
    "logging": {
      "level": "OFF"
    }
  }
}

Actual behavior

I am still seeing log traces appear in azure monitor

To Reproduce

Set config as described above and check if trace logs are being sent

@multicaststorm
Copy link
Author

From a quick scan through the code, I think that it is expecting 'threshold' instead of 'level'

{
  "instrumentation": {
    "logging": {
      "threshold": "OFF"
    }
  }
}

...so either the code or the documentation is incorrect

@trask
Copy link
Member

trask commented Dec 18, 2020

oh no, thanks!! will be fixed in next release by #1416

@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants