Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Insights showing 200 for failed requests #810

Closed
DineshAyyapillai opened this issue Jan 29, 2019 · 9 comments · Fixed by #1011
Closed

Application Insights showing 200 for failed requests #810

DineshAyyapillai opened this issue Jan 29, 2019 · 9 comments · Fixed by #1011
Assignees

Comments

@DineshAyyapillai
Copy link

Even from the latest application insights version 2.3.0, the Response code issue which is described in the below fix is not resolved,

#603

Did we find any better alternatives or solution for the issue?

With Regards,
Dinesh Ayyapillai.

@littleaj
Copy link
Contributor

@DineshAyyapillai
Unfortunately, that issue still exists in the filter, but we may be able to find a workaround. I just need some additonal information:

  • Just want to confirm that this is with RequestTelemetry, correct?
  • Are you using SpringBoot?
  • Are you using other filters?
  • Are you using custom error pages?
  • Is the success field correct?

@dhaval24
Copy link
Contributor

@DineshAyyapillai, also please mention how you have instrumented your application. Are you using Springboot starter, or just plain SDK?
We had fixed this problem for Springboot starter case mostly with #766

@DineshAyyapillai
Copy link
Author

@littleaj

  • Yeah it is RequestTelemetry,
  • We are using SpringBoot
  • No, We are using "appInsightsWebRequestTrackingFilter"
  • We are not using the custom error pages
  • No, It's incorrect showing "Successful on failed request"
  • @dhaval24 - We are using and we set the precedence order as "1"

@dhaval24
Copy link
Contributor

@DineshAyyapillai thanks for mentioning that. @littleaj has a little more context on non springboot scenarios. Often it is possible that sometimes an error code is set in the request telemetry after the object escapes the filter chain. i.e by some error handler etc. In that case it is likely that request telemetry object might miss the result code.

Also, it might be possible if you are using Async servlet request it might have issues similar to that. If possible .

@dhaval24
Copy link
Contributor

Essentially this is dup of #600

@dhaval24 dhaval24 added the Bug label Jan 31, 2019
@DineshAyyapillai
Copy link
Author

@dhaval24 Yeah, It's almost similar but any idea on whether the issue will be fixed in the upcoming releases of application insights or any alternative solutions to work on.

@lmolkova
Copy link
Member

lmolkova commented Feb 7, 2019

we recommend manually tracking requests to handle async responses. We'll be providing guidance and code snippets to help with this in the next few weeks.

at this point, we do not have an estimate on supporting it out of the box in ApplicationInsights SDK.

@dhaval24 dhaval24 added Enhancement and removed Bug labels Feb 8, 2019
@dhaval24
Copy link
Contributor

dhaval24 commented Feb 8, 2019

moved the label to enhancements, as this is more about handling async requests.

@dhaval24
Copy link
Contributor

dhaval24 commented Feb 11, 2019

@DineshAyyapillai could you please also explain you entire scenario of how you are using async requests, so that we can capture the scenario correctly.
Ideally a code snippet / small sample app would be of great help.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants