Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOV] Firewall fqdns should be sourced from ServiceTags #3286

Closed
1 task
LizaShak opened this issue Mar 1, 2023 · 1 comment
Closed
1 task

[GOV] Firewall fqdns should be sourced from ServiceTags #3286

LizaShak opened this issue Mar 1, 2023 · 1 comment
Assignees
@tamirkamara
Labels
story Stories are the smallest unit of work to be done for a project.

Comments

@LizaShak
Copy link
Contributor

LizaShak commented Mar 1, 2023 •
edited
Loading

Description

As an Azure TRE Developer
I want the cloud related FQDNS added to firewall to be sourced from ServiceTags
So that it is easier to maintain.

Technical notes:

  • A core example is the /workspaces/AzureTRE/templates/shared_services/firewall/terraform/rules.tf
  • Try replacing those with ServiceTags
  • Think of away to reduce the hardcoded parts

Acceptance criteria

  • FQDNS added to firewall are adjustable to the cloud it deployed in
@LizaShak LizaShak added the story Stories are the smallest unit of work to be done for a project. label Mar 1, 2023
@tamirkamara tamirkamara mentioned this issue Mar 1, 2023
Closed
@LizaShak LizaShak changed the title Firewall fqdns should support multiple clouds Firewall fqdns should be sourced from ServiceTags Mar 2, 2023
@tamirkamara
Copy link
Collaborator

We said that the FQDNs currently used in the shared service should probably move to the admin-vm service. This would make this less of a priority to fix.

@LizaShak LizaShak changed the title Firewall fqdns should be sourced from ServiceTags [GOV] Firewall fqdns should be sourced from ServiceTags Mar 5, 2023
@tamirkamara tamirkamara mentioned this issue Mar 7, 2023
Merged
@LizaShak LizaShak closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tamirkamara tamirkamara

Labels
story Stories are the smallest unit of work to be done for a project.
Projects
Azure TRE - Engineering
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tamirkamara @LizaShak