Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOV] Authority passed to services should be dynamically sourced #3287

Closed
1 task
LizaShak opened this issue Mar 1, 2023 · 1 comment
Closed
1 task

[GOV] Authority passed to services should be dynamically sourced #3287

LizaShak opened this issue Mar 1, 2023 · 1 comment
Labels
story Stories are the smallest unit of work to be done for a project.

Comments

@LizaShak
Copy link
Contributor

LizaShak commented Mar 1, 2023 •
edited
Loading

Description

As a Azure TRE Developer
I want to eliminate the hardcoded login.microsoftonline.com passed as authority
So that I can deploy our solution in multiple clouds

Technical notes:

  • Search for all the places where login.microsoftonline.com is passed as authority/issuer
  • Think of a design how to source it dynamically or with a config that easy to change when deployed on another cloud

Acceptance criteria

  • login.microsoftonline.com is sourced based on the target cloud type
@LizaShak LizaShak added the story Stories are the smallest unit of work to be done for a project. label Mar 1, 2023
@LizaShak LizaShak changed the title Eliminate hardcoded login.microsoftonline.com Authority passed to services should be dynamically sourced Mar 2, 2023
@tamirkamara
Copy link
Collaborator

Is this the same Authority that corresponds to one in which the workspace app was create in?

@yuvalyaron yuvalyaron mentioned this issue Mar 2, 2023
Merged
@LizaShak LizaShak mentioned this issue Mar 2, 2023
Closed
@LizaShak LizaShak changed the title Authority passed to services should be dynamically sourced [GOV] Authority passed to services should be dynamically sourced Mar 5, 2023
@LizaShak LizaShak closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
story Stories are the smallest unit of work to be done for a project.
Projects
Azure TRE - Engineering
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tamirkamara @LizaShak