Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Guacamole deps 1.5.1 #3443

Merged
merged 7 commits into from
Apr 17, 2023

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

With Guacamole 1.5.* the base image of guacd has move to alpine which requires a bunch of changes in the bundle.

How is this addressed

  • Update all Guacamole dependencies to 1.5.1 (base image, war, jar - although it's provided).
  • Use apk to install OS dependencies including openjdk11 (which has previously been manually installed).
  • Generate host RSA keys as those aren't generated automatically in alpine
  • Update s6 run script for guacd as it changed location
  • Update terraform binary and providers

Base automatically changed from tamirkamara/fix-git-install-in-bundle to main April 16, 2023 18:08
@tamirkamara tamirkamara force-pushed the tamirkamara/upgrade-guacamole-deps-1.5.1 branch from f484155 to a05d44e Compare April 16, 2023 18:54
@tamirkamara tamirkamara marked this pull request as ready for review April 16, 2023 18:55
@github-actions
Copy link

github-actions bot commented Apr 16, 2023

Unit Test Results

15 tests   15 ✔️  2s ⏱️
  4 suites    0 💤
  4 files      0

Results for commit 8b35379.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4717516920 (with refid 1fe812b0)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4720286643 (with refid 1fe812b0)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4721895570 (with refid 1fe812b0)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) April 17, 2023 14:18
Copy link
Collaborator

@anatbal anatbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamirkamara tamirkamara merged commit 06a68c2 into main Apr 17, 2023
@tamirkamara tamirkamara deleted the tamirkamara/upgrade-guacamole-deps-1.5.1 branch April 17, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants