Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker not building #4435

Closed
2 tasks
cdonke opened this issue Oct 20, 2020 · 5 comments · Fixed by #4461
Closed
2 tasks

Docker not building #4435

cdonke opened this issue Oct 20, 2020 · 5 comments · Fixed by #4461
Assignees
Labels

Comments

@cdonke
Copy link
Contributor

cdonke commented Oct 20, 2020

Describe the bug

Using Docker to run Composer.
Several issues started happening after moving Extensions folder from Composer into root.

Most of them, during build process..

Wrong path:
image
image

Git is now required for some module, but it's not present on container.

Timeouts:
image

Version

Latest merge - 00df46c

OS

  • macOS
  • Windows
  • [ X ] Ubuntu

To Reproduce

Steps to reproduce the behavior:

cd ~/
~/BotFramework-Composer
docker build -t bot-composer -f ./Composer/Dockerfile .

Expected behavior

Container image is created.

@cdonke cdonke added Needs-triage A new issue that require triage Type: Bug Something isn't working labels Oct 20, 2020
@cdonke
Copy link
Contributor Author

cdonke commented Oct 20, 2020

Already investigating.

@a-b-r-o-w-n
Copy link
Contributor

Hi @cdonke. Sorry for the breaking change! I am working on a fix for this. Do you usually build the docker image from the root directory or were you trying that because the extensions directory was moved up?

In my investigation, I've found that we will need to send the entire repository as context to the docker build, along with copying the correct files during the build process. I think in order to facilitate this, moving the Dockerfile up to the root would make sense. Do you have any concerns about doing this?

@cdonke
Copy link
Contributor Author

cdonke commented Oct 20, 2020

Hi @a-b-r-o-w-n ...

I'm building from the root...
Already made some changes for the dockerfile (making better use of docker cache, moving some things around to improve)...

Now, I'm stuck here:

image

Should I stop, or can I help you somehow?

tks,

@cdonke
Copy link
Contributor Author

cdonke commented Oct 20, 2020

@a-b-r-o-w-n , Here is the repo I'm working on:

https://github.com/cdonke/BotFramework-Composer/tree/fix/dockerbuild

I took the opportunity to write a GitHub Action to build the containers to test it on PR as well...
It's there too..

@a-b-r-o-w-n
Copy link
Contributor

I'd say continue with your work as well. It looks like you are more experienced with docker than our team is. I will continue working on it as well and tag you are a reviewer on a PR. At that point, feel free to make suggestions with the things you've done to improve the docker build. We can integrate it into the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants