-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker not building #4435
Comments
Already investigating. |
Hi @cdonke. Sorry for the breaking change! I am working on a fix for this. Do you usually build the docker image from the root directory or were you trying that because the extensions directory was moved up? In my investigation, I've found that we will need to send the entire repository as context to the docker build, along with copying the correct files during the build process. I think in order to facilitate this, moving the Dockerfile up to the root would make sense. Do you have any concerns about doing this? |
Hi @a-b-r-o-w-n ... I'm building from the root... Now, I'm stuck here: Should I stop, or can I help you somehow? tks, |
@a-b-r-o-w-n , Here is the repo I'm working on: https://github.com/cdonke/BotFramework-Composer/tree/fix/dockerbuild I took the opportunity to write a GitHub Action to build the containers to test it on PR as well... |
I'd say continue with your work as well. It looks like you are more experienced with docker than our team is. I will continue working on it as well and tag you are a reviewer on a PR. At that point, feel free to make suggestions with the things you've done to improve the docker build. We can integrate it into the PR. |
Describe the bug
Using Docker to run Composer.
Several issues started happening after moving Extensions folder from Composer into root.
Most of them, during build process..
Wrong path:
Git is now required for some module, but it's not present on container.
Timeouts:
Version
Latest merge - 00df46c
OS
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Container image is created.
The text was updated successfully, but these errors were encountered: